Fix issue with "Change email" behavior in Link#10706
Draft
tillh-stripe wants to merge 1 commit intomasterfrom
Draft
Fix issue with "Change email" behavior in Link#10706tillh-stripe wants to merge 1 commit intomasterfrom
tillh-stripe wants to merge 1 commit intomasterfrom
Conversation
tillh-stripe
commented
Apr 23, 2025
| get() { | ||
| val clearCustomerDetails = linkAccount == null | ||
| val effectiveCustomerInfo = if (clearCustomerDetails) { | ||
| LinkConfiguration.CustomerInfo(null, null, null, null) |
Collaborator
Author
There was a problem hiding this comment.
I was thinking of only setting the email address to null and keeping the other values as-is, but Web seems to fully clear the customer info for the same flow.
tillh-stripe
commented
Apr 23, 2025
| DaggerNativeLinkComponent | ||
| .builder() | ||
| .configuration(args.configuration) | ||
| .configuration(args.configurationWithUpdatedCustomerInfo) |
Collaborator
Author
There was a problem hiding this comment.
Might be weird that this happens here, but if we don't update the configuration, then this code will fetch the Link account associated with that email address.
Contributor
|
Diffuse output: APK |
tillh-stripe
force-pushed
the
tillh/fix-link-change-email-issue
branch
from
f726bfa to
e2f1285
Compare
After selecting "Change email" and closing the flow, we now show the signup screen on re-open instead of the verification screen.
tillh-stripe
force-pushed
the
tillh/fix-link-change-email-issue
branch
from
e2f1285 to
3369932
Compare
toluo-stripe
approved these changes
Apr 23, 2025
Contributor
carlosmuvi-stripe
left a comment
carlosmuvi-stripe
left a comment
There was a problem hiding this comment.
LGTM! one small comment
|
|
||
| internal class NoArgsException : IllegalArgumentException("NativeLinkArgs not found") | ||
|
|
||
| private val NativeLinkArgs.configurationWithUpdatedCustomerInfo: LinkConfiguration |
Contributor
There was a problem hiding this comment.
nit - I think this is more understandable as an extension function of LinkConfiguration, so that it reads:
args.configuration.withUpdatedCustomerInfo(args.LinkAccount) - might be a bit more verbose on the other hand so leave it as is if it makes sense!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes an issue with the “Change email” behavior in Link.
After selecting “Change email” and closing the flow, we now show the signup screen on re-open instead of the verification screen. This makes more sense, since the user already indicated that they don't want to use the email address that we pull from the
CustomerInfoobject.Motivation
LINK_MOBILE-165
Testing
Screen recordings
Before
Screen_recording_20250423_113043.mp4
After
Screen_recording_20250423_112842.mp4
Changelog